Segmentation fault in c when reading a line -


i want read user input(like terminal) until exit written or ctrl+c/ctrl+d pressed. read every line(until return/enter pressed), check if it's space or comment(#) , execute functions.

i tried 3 methods, no success. error every time insert string , press enter

char line[256]; while(printf("%s>", shell_name) && scanf("%50[^\n]", line) != eof) {

segmentation fault (core dumped)

while(printf("%s>", shell_name) && getline(line, 100, stdin) != eof)

note: expected ‘size_t * restrict’ argument of type ‘int’

while(printf("%s>", shell_name) && fgets(line, sizeof(line), stdin) != null) {

segmentation fault (core dumped)

for more orientation i'm doing next 

if(isspace(&line) == 0 && &line[0] != "#")

what doing wrong? there more suitable/easy/better option?

the segfault kicks in because enter infinite loop: scanf("%50[^\n]", line) reads input , stops @ return. return not consumed , stays in input buffer. happens next time around? scanf checks input buffer, , hey! there return! stops reading. et cetera.

adding space first character inside scanf format string resolves that:

int main() {     char line[256];     char *shell_name = "mysh";      while (printf("%s>", shell_name) && scanf(" %50[^\n]", line) != eof)     {         printf ("you entered [%s]\n", line);     }     printf ("done.\n");     return 0; }

on further note, wrong:

if(isspace(&line) == 0 && &line[0] != "#")

-- gcc complains

warning: passing argument 1 of 'isspace' makes integer pointer without cast warning: comparison string literal results in unspecified behavior

the first on isspace(&line), meant isspace(line[0]), second on &line[0] != "#", can written more concisely line[0] != '#'.

on getline

getline works different other "get stdin" functions, because automatically allocate memory if asked to. since needs return not one, three results (the number of characters, string entered, , length) need provide pointers string , size arguments:

size_t line_size = 0; char *ptr_to_line = null;  while (printf("%s>", shell_name) && getline(&ptr_to_line, &line_size, stdin) != -1)       ...

when using way, should not use static string size allocation, function fill in appropriate values. (but don't forget uses malloc , realloc internally, make sure free result. uses malloc first time, realloc after resize.)


Comments

Post a Comment

Popular posts from this blog

commonjs - How to write a typescript definition file for a node module that exports a function? -

consider, toml node module can use: // toml.d.ts declare module toml { export function parse(value:string):any; } declare module "toml" { export = toml; } then: /// <reference path="../../../../../defs/toml/toml.d.ts"/> import toml = require('toml'); toml.parse(...); however, node module export single function, such 'glob' ( https://github.com/isaacs/node-glob ). the node usage of module be: var glob = require("glob") glob("*.js", {}, callback(err, files) { ... }); you'd naively expect this: // glob.d.ts declare function globs(paths:string, options:any, callback:{(err:any, files:string[]):void; ...but because typescripts 'import' semantics bit strange, seems can use 'import .. = require()' statement alias modules . trying call: /// <reference path="../../../../../defs/glob/glob.d.ts"/> import blog = require('glob'); results in: error ts2072: mod...
Read more

openid - Okta: Failed to get authorization code through API call -

i'm integrating okta own idp server using okta's api. i'm implementing authorization code flow following steps below: in own server, use /api/v1/authn endpoint sessiontoken. use sessiontoken obtain authorization calling endpoint: /oauth2/v1/authorize?client_id=" + clientid + "&sessiontoken=" + sessiontoken + "&response_type=code&response_mode=query&scope=openid&redirect_uri=" + redirecturl + "&state=evanyang&nonce=" it's supposed return response status code 302 , location header containing redirect url code value. however, keep getting response status code 200 , without location header, html body saying "you using unsupported browser." , "javascript disabled on browser." according api documentation: http://developer.okta.com/docs/api/resources/oidc.html#authentication-request , sessiontoken parameter sufficient this: an okta one-time sessiontoken. allows api-based ...
Read more

ios - Change Storyboard View using Seague -

i have following code checks connection server, , depending on want change views if no connection found. nsstring *connect = [nsstring stringwithcontentsofurl:[nsurl urlwithstring:@"http://myserver.com"] encoding:nsutf8stringencoding error:nil]; if (connect == null) { [self performseguewithidentifier:@"network_failure" sender:self]; } else { // other code here } my problem not change views. have added storyboard segue between 2 views identifier of network_failure . not have navigation controller or that, problem? thanks help! no not problem. first of all, in objectivec exists nil object oriented null . must use that. so: if(connect == nil) or better: if(!connect) so due fact nil not same of null , probably code does't enter in if scope . you have been able discover breakpoint. anyway: be sure set trigger segue (line) 2 view controller , , name network_failure (that not best name. should instead view1toview2 ) as, m...
Read more