Creating a java string randomizer from an array Android -


i trying create password generator (random string generator) send database when use below code in activity app terminates error "java.lang.arrayindexoutofboundsexception: length=67; index=85" code should return random value character array using loop generate string. 

package com.example.zakratcliffe.androidantitheft;  import android.content.intent; import android.support.v7.app.appcompatactivity; import android.os.bundle; import android.view.menu; import android.view.menuitem; import android.view.view; import android.widget.button; import android.widget.edittext; import android.widget.textview;  import java.util.random;  public class profileactivity extends appcompatactivity {   private textview textviewusername, textviewuseremail; private edittext texteditdescription, texteditpassword;  @override protected void oncreate(bundle savedinstancestate) {     super.oncreate(savedinstancestate);     setcontentview(r.layout.activity_profile);      if (!sharedprefmanager.getinstance(this).isloggedin()) {         finish();         startactivity(new intent(this, loginactivity.class));     }      textviewusername = (textview) findviewbyid(r.id.textviewusername);     textviewuseremail = (textview) findviewbyid(r.id.textviewuseremail);     texteditdescription = (edittext) findviewbyid(r.id.edittextdescription);     texteditpassword = (edittext) findviewbyid(r.id.edittextpassword);      textviewuseremail.settext(sharedprefmanager.getinstance(this).getuseremail());     textviewusername.settext(sharedprefmanager.getinstance(this).getusername());      final button button = (button) findviewbyid(r.id.generate_button);     button.setonclicklistener(new view.onclicklistener() {         @override         public void onclick(view v) {             string pass = generated_pass();             texteditpassword.settext(pass);         }     }); }  string generated_pass(){     char[] genpass = {'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '@', '!', '?', '&', '%', '~'};     int = 1;     string generatedpass = "";     while (i < 13){         random r = new random();         int character = r.nextint(66 - 0) + 66;         system.out.println(genpass[character]);         generatedpass = generatedpass + genpass[character];         i++;     }     return  generatedpass; } public void sendtodb(view v){ } @override public boolean oncreateoptionsmenu(menu menu) {     getmenuinflater().inflate(r.menu.menu, menu);     return true; }  @override public boolean onoptionsitemselected(menuitem item) {     switch(item.getitemid()){         case r.id.menulogout:             sharedprefmanager.getinstance(this).logout();             finish();             startactivity(new intent(this, loginactivity.class));             break;     }     return true; } }

do

int character = r.nextint(66);

instead of

int character = r.nextint(66 - 0) + 66;

as "r.nextint(66-0) + 66" may generate random number between 0 66, , number 66 added, character has value more 66, inaccessible in array(has length 66), , hence exception arrayindexoutofboundsexception.

or make code robust, instead of hardcoding 66, use: 

    while (i < 13){         random r = new random();         int character = r.nextint(genpass.length);         system.out.println(genpass[character]);         generatedpass = generatedpass + genpass[character];         i++;     }     return  generatedpass; }

Comments

Post a Comment

Popular posts from this blog

inversion of control - Autofac named registration constructor injection -

does autofac support specifying registration name in components' constructors? example: ninject's namedattribute . you need use autofac.extras.attributed package on top achieve this so let's have 1 interface , 2 classes: public interface ihello { string sayhello(); } public class englishhello : ihello { public string sayhello() { return "hello"; } } public class frenchhello : ihello { public string sayhello() { return "bonjour"; } } then have consumer class, in want select instance injected: public class helloconsumer { private readonly ihello helloservice; public helloconsumer([withkey("en")] ihello helloservice) { if (helloservice == null) { throw new argumentnullexception("helloservice"); } this.helloservice = helloservice; } public string sayhello() { return this.helloservice.sayhello()...
Read more

verilog - Systemverilog dynamic casting issues -

i've code snippet following in testbench function void write_to_port( my_data_type_base data ); my_data_type_extended data_ext; if(!$cast(data_ext, data)); `uvm_error(get_type_name(), "failed cast"); `uvm_info(get_name(), $psprintf("data_ext :\n%s", data_ext.sprint()), uvm_medium) // write data_ext out port.... endfunction when run it, i'm getting uvm_error "failed cast." i'm not quire sure why $cast not returning 1. can see, i'm printing out extended class data item after casting uvm_info. can see it's being cast properly. if don't use $cast if condition, don't runtime error. isn't coding practice use if dynamic cast check if $cast returning 1 ? what might reason behind cast not returning 1 in above case? i think semicolon on line 'if' not belong? i think consumes if statement, , uvm_error executes regardless of how if evaluates: if(!$cast(data_ext, data)); <- no semico...
Read more

ios - Change Storyboard View using Seague -

i have following code checks connection server, , depending on want change views if no connection found. nsstring *connect = [nsstring stringwithcontentsofurl:[nsurl urlwithstring:@"http://myserver.com"] encoding:nsutf8stringencoding error:nil]; if (connect == null) { [self performseguewithidentifier:@"network_failure" sender:self]; } else { // other code here } my problem not change views. have added storyboard segue between 2 views identifier of network_failure . not have navigation controller or that, problem? thanks help! no not problem. first of all, in objectivec exists nil object oriented null . must use that. so: if(connect == nil) or better: if(!connect) so due fact nil not same of null , probably code does't enter in if scope . you have been able discover breakpoint. anyway: be sure set trigger segue (line) 2 view controller , , name network_failure (that not best name. should instead view1toview2 ) as, m...
Read more