Having trouble in c# fraction calculator -


i have assignment due tomorrow has add , subtract fractions whole numbers, , i'm getting bit confused these numbers, , math isn't helping either.

it's performing math correctly, keeps putting 1 whole variable when should 0 , can't figure out life of me why.

here's fraction.cs:

class fraction {     int num, den, whole, newnum;      public fraction(int numerator, int denominator, int whole = 0)     {          this.num = numerator;         this.den = denominator;         this.whole = whole;     }      public fraction add(fraction other)     {         int temp1 = num, temp2 = den;         if (math.abs(this.whole) > 0)         {             newnum = temp2 * whole;             newnum = +temp1;             temp1 = newnum;         }         if (math.abs(other.whole) > 0)         {             other.newnum = other.den * other.whole;             other.newnum = +other.num;             other.num = other.newnum;         }         temp1 = temp1 * other.den + temp2 * other.num;         temp2 = temp2 * other.den;         if (temp1 == temp2 || temp1 > temp2)         {             whole = temp1 / temp2;             temp1 = temp1 % temp2;         }          fraction newfrac = new fraction(temp1, temp2, whole);         return newfrac;     } }

and inside program.cs here's test:

fraction fra1 = new fraction(1, 2); fraction fra2 = new fraction(3, 4, 1); fraction fra3 = fra1.add(fra2); console.writeline("fraction 1: " + fra1); console.writeline("fraction 2: " + fra2); console.writeline("{0} + {1} = {2}", fra1, fra2, fra3);

and here's i'm getting result:

enter image description here

any appreciated! in advanced. austen

i think problem line:

whole = temp1 / temp2

it seems you're accidently modifying whole value of current instance. that's what's causing fra1 'magically' change 1/2 1 1/2. use temporary variable instead , should fix problem, i'd recommend making similar adjustments avoid accidentally modifying fields of other removing newnum field apparently there temporary placeholder calculations.

if intend make class immutable, i'd recommend making each of fields readonly avoid these errors.


Comments

Post a Comment

Popular posts from this blog

commonjs - How to write a typescript definition file for a node module that exports a function? -

consider, toml node module can use: // toml.d.ts declare module toml { export function parse(value:string):any; } declare module "toml" { export = toml; } then: /// <reference path="../../../../../defs/toml/toml.d.ts"/> import toml = require('toml'); toml.parse(...); however, node module export single function, such 'glob' ( https://github.com/isaacs/node-glob ). the node usage of module be: var glob = require("glob") glob("*.js", {}, callback(err, files) { ... }); you'd naively expect this: // glob.d.ts declare function globs(paths:string, options:any, callback:{(err:any, files:string[]):void; ...but because typescripts 'import' semantics bit strange, seems can use 'import .. = require()' statement alias modules . trying call: /// <reference path="../../../../../defs/glob/glob.d.ts"/> import blog = require('glob'); results in: error ts2072: mod...
Read more

openid - Okta: Failed to get authorization code through API call -

i'm integrating okta own idp server using okta's api. i'm implementing authorization code flow following steps below: in own server, use /api/v1/authn endpoint sessiontoken. use sessiontoken obtain authorization calling endpoint: /oauth2/v1/authorize?client_id=" + clientid + "&sessiontoken=" + sessiontoken + "&response_type=code&response_mode=query&scope=openid&redirect_uri=" + redirecturl + "&state=evanyang&nonce=" it's supposed return response status code 302 , location header containing redirect url code value. however, keep getting response status code 200 , without location header, html body saying "you using unsupported browser." , "javascript disabled on browser." according api documentation: http://developer.okta.com/docs/api/resources/oidc.html#authentication-request , sessiontoken parameter sufficient this: an okta one-time sessiontoken. allows api-based ...
Read more

ios - Change Storyboard View using Seague -

i have following code checks connection server, , depending on want change views if no connection found. nsstring *connect = [nsstring stringwithcontentsofurl:[nsurl urlwithstring:@"http://myserver.com"] encoding:nsutf8stringencoding error:nil]; if (connect == null) { [self performseguewithidentifier:@"network_failure" sender:self]; } else { // other code here } my problem not change views. have added storyboard segue between 2 views identifier of network_failure . not have navigation controller or that, problem? thanks help! no not problem. first of all, in objectivec exists nil object oriented null . must use that. so: if(connect == nil) or better: if(!connect) so due fact nil not same of null , probably code does't enter in if scope . you have been able discover breakpoint. anyway: be sure set trigger segue (line) 2 view controller , , name network_failure (that not best name. should instead view1toview2 ) as, m...
Read more