ruby on rails - Sanitising a download URL with params being passed to send_file -


i have numerous files in directory app/assets/downloadables/ , want authenticated users able download arbitrary files name in params within directory or subdirectories.

how can sanitise input send_file prevent users accessing arbitrary files on server?

at moment i'm looking @ doing this, i'm not confident it's safe:

downloads_root = file.join(rails.root, "app", "assets", "downloadables") # e.g. request.path = "/downloads/subdir/file1.pdf" file = request.path.gsub(/^\/downloads\//,'').gsub('..','').split('/') # send file /app/assets/downloadables/subdir/file1.pdf send_file file.join(downloads_root, file)

would sufficiently protect against app-wide arbitrary file access or there improvements or different approach better?

i found answer here: http://makandracards.com/makandra/1083-sanitize-user-generated-filenames-and-only-send-files-inside-a-given-directory

this file needed created per link:

app/controllers/shared/send_file_inside_trait.rb

module applicationcontroller::sendfileinsidetrait   as_trait    private      def send_file_inside(allowed_path, filename, options = {})       path = file.expand_path(file.join(allowed_path, filename))       if path.match regexp.new('^' + regexp.escape(allowed_path))         send_file path, options       else         raise 'disallowed file requested'       end     end    end end

to used follows in controllers:

send_file_inside file.join(rails.root, 'app', 'assets', 'downloadables'), request.path.gsub(/^\/downloads\//,'').split('/')

the magic happens calculated path of allowed_path + file_name entered expand_path strip out special directory browsing strings , return absolute path. resolved path compared against allowed_path ensure file being requested resides within allowed path and/or sub-directories.

note solution requires modularity gem v2 https://github.com/makandra/modularity


Comments

Post a Comment

Popular posts from this blog

commonjs - How to write a typescript definition file for a node module that exports a function? -

consider, toml node module can use: // toml.d.ts declare module toml { export function parse(value:string):any; } declare module "toml" { export = toml; } then: /// <reference path="../../../../../defs/toml/toml.d.ts"/> import toml = require('toml'); toml.parse(...); however, node module export single function, such 'glob' ( https://github.com/isaacs/node-glob ). the node usage of module be: var glob = require("glob") glob("*.js", {}, callback(err, files) { ... }); you'd naively expect this: // glob.d.ts declare function globs(paths:string, options:any, callback:{(err:any, files:string[]):void; ...but because typescripts 'import' semantics bit strange, seems can use 'import .. = require()' statement alias modules . trying call: /// <reference path="../../../../../defs/glob/glob.d.ts"/> import blog = require('glob'); results in: error ts2072: mod
Read more

openid - Okta: Failed to get authorization code through API call -

i'm integrating okta own idp server using okta's api. i'm implementing authorization code flow following steps below: in own server, use /api/v1/authn endpoint sessiontoken. use sessiontoken obtain authorization calling endpoint: /oauth2/v1/authorize?client_id=" + clientid + "&sessiontoken=" + sessiontoken + "&response_type=code&response_mode=query&scope=openid&redirect_uri=" + redirecturl + "&state=evanyang&nonce=" it's supposed return response status code 302 , location header containing redirect url code value. however, keep getting response status code 200 , without location header, html body saying "you using unsupported browser." , "javascript disabled on browser." according api documentation: http://developer.okta.com/docs/api/resources/oidc.html#authentication-request , sessiontoken parameter sufficient this: an okta one-time sessiontoken. allows api-based
Read more

thorough guide for profiling racket code -

did googling ("racket profiling", "racket measure performance"), didn't find , there no examples in docs. did google "profile" search on htdp - no luck. (profile (f ...)) output isn't obvious other small snippets. ideally want python's python -m cprofile usage examples. when search "python profiling", both duckduckgo , google give top result: 26.4. python profilers . (although scanned quickly, seems more of reference "thorough usage guide" examples. if had else in mind, perhaps please link that?) the equivalent racket documentation be: profile: statistical profiler . a usage example: #lang racket (require profile) (profile-thunk (thunk (function-to-profile arg0 arg1) )) here (thunk e) convenience (lambda () e) . bigger example: #lang racket (module mod racket (provide f) (define (f) (for/list ([i 10000]) i))) (require (prefix-in mod: 'mod)) (define (f) (for ([i 10000
Read more