javascript - Attempting synchronous behaviour with shell script execution in node.js -


i'm quite new node.js , i'm using server receive http.get requests browser, processing , return result browser.

the processing scraping website using phantom.js/casper.js , because of complications using casper.js in node.js i'm executing sub-process use of shell script.

when run code below , make request browser, response seems appear before shell script has run. tried using async library run steps in series run.sh runs , returns value before it's added response doesn't seem work that. can spot stupid mistake?

thanks in advance!

var express = require('express'); var app = express(); var sys = require('sys'); var exec = require('child_process').exec; var async = require('async'); var auth = express.basicauth('test', 'pass'); var server = app.listen(3000, function() {     console.log('listening on port %d', server.address().port); }); var result;   //app.use(auth);  app.get('/free/:u/:p', auth, function(req, res) {      async.series([         function(callback){             var puts = function (error, stdout, stderr) {                 result = stdout;              }              exec("./run.sh " + req.params.u + " " + req.params.p, puts);              callback(null);         },         function(callback){              res.writehead(200,{'content-type':'application/json'});              res.send(result)              callback(null);         }     ]); });  app.get('/', function(req, res) {   res.send('hello!'); });

you're not calling callback(null) asynchronously. need put in puts.

also, shouldn't use global results variable (it's global across requests, possibly leaking data different clients - arghh!). , there's hardly reason use async.js trivial chain.

app.get('/free/:u/:p', auth, function(req, res) {      exec("./run.sh " + req.params.u + " " + req.params.p, function (error, stdout, stderr) {        res.writehead(200,{'content-type':'application/json'});        res.send(stdout);     }); });

notice security issue introduced not escaping shell parameters.


Comments

Post a Comment

Popular posts from this blog

commonjs - How to write a typescript definition file for a node module that exports a function? -

consider, toml node module can use: // toml.d.ts declare module toml { export function parse(value:string):any; } declare module "toml" { export = toml; } then: /// <reference path="../../../../../defs/toml/toml.d.ts"/> import toml = require('toml'); toml.parse(...); however, node module export single function, such 'glob' ( https://github.com/isaacs/node-glob ). the node usage of module be: var glob = require("glob") glob("*.js", {}, callback(err, files) { ... }); you'd naively expect this: // glob.d.ts declare function globs(paths:string, options:any, callback:{(err:any, files:string[]):void; ...but because typescripts 'import' semantics bit strange, seems can use 'import .. = require()' statement alias modules . trying call: /// <reference path="../../../../../defs/glob/glob.d.ts"/> import blog = require('glob'); results in: error ts2072: mod...
Read more

openid - Okta: Failed to get authorization code through API call -

i'm integrating okta own idp server using okta's api. i'm implementing authorization code flow following steps below: in own server, use /api/v1/authn endpoint sessiontoken. use sessiontoken obtain authorization calling endpoint: /oauth2/v1/authorize?client_id=" + clientid + "&sessiontoken=" + sessiontoken + "&response_type=code&response_mode=query&scope=openid&redirect_uri=" + redirecturl + "&state=evanyang&nonce=" it's supposed return response status code 302 , location header containing redirect url code value. however, keep getting response status code 200 , without location header, html body saying "you using unsupported browser." , "javascript disabled on browser." according api documentation: http://developer.okta.com/docs/api/resources/oidc.html#authentication-request , sessiontoken parameter sufficient this: an okta one-time sessiontoken. allows api-based ...
Read more

ios - Change Storyboard View using Seague -

i have following code checks connection server, , depending on want change views if no connection found. nsstring *connect = [nsstring stringwithcontentsofurl:[nsurl urlwithstring:@"http://myserver.com"] encoding:nsutf8stringencoding error:nil]; if (connect == null) { [self performseguewithidentifier:@"network_failure" sender:self]; } else { // other code here } my problem not change views. have added storyboard segue between 2 views identifier of network_failure . not have navigation controller or that, problem? thanks help! no not problem. first of all, in objectivec exists nil object oriented null . must use that. so: if(connect == nil) or better: if(!connect) so due fact nil not same of null , probably code does't enter in if scope . you have been able discover breakpoint. anyway: be sure set trigger segue (line) 2 view controller , , name network_failure (that not best name. should instead view1toview2 ) as, m...
Read more