excel - VBA code in command button doesn't work on button click -


i'm don't know vba , i'm doing out of necessity forgive me. t-sql.

i found following code in article take data excel sheet , output txt file used run through scribe. far;

  1. i've placed command button on sheet
  2. i've right clicked view code
  3. i pasted code article vba editor , adapted parts of needs (the file path basically)

when run code editor performs perfectly.

when close editor , click button on sheet runs resulting text file appropriate number of empty strings in text file. it's can see number of rows have data not actual data in cells.

have missed obvious? can't see more in article (which isn't written complete novices have say) solve problem!

sub commandbutton1_click()  dim filepath string dim rng range dim celldata string dim lastcol long dim lastrow long  lastcol = activesheet.usedrange.specialcells(xlcelltypelastcell).column  lastrow = activesheet.usedrange.specialcells(xlcelltypelastcell).row  set rng = worksheets("discount template").range("b3")  filepath = "\\server2012\it dept\accesssupplychain\product discount uploads\" & rng.value & "_" & format(now(), "yyyymmdd hhmmss") & ".txt"  open filepath output #2  = 1 lastrow      j = 1 lastcol          if j = lastcol         celldata = celldata + trim(activecell(i, j).value)          else          celldata = celldata + trim(activecell(i, j).value) + ","      end if  next j  print #2, celldata celldata = ""  next  close #2 msgbox ("done")  end sub

the issue use of activecell not obliged a1 cell!

so want change activecell(i, j) cells(i, j)

but propose following refactoring of code:

option explicit  private sub commandbutton1_click()     dim filepath string     dim rng range     dim irow long      set rng = worksheets("discount template").range("b3")      filepath = "\\server2012\it dept\accesssupplychain\product discount uploads\" & rng.value & "_" & format(now(), "yyyymmdd hhmmss") & ".txt"      open filepath output #2     usedrange '<--| reference active sheet used range         irow = 1 .rows.count '<--| loop through rows             print #2, join(application.transpose(application.transpose(.rows(irow))), ",") '<--| print whole current row in 1 shot          next     end     close #2     msgbox ("done") end sub

Comments

Post a Comment

Popular posts from this blog

commonjs - How to write a typescript definition file for a node module that exports a function? -

consider, toml node module can use: // toml.d.ts declare module toml { export function parse(value:string):any; } declare module "toml" { export = toml; } then: /// <reference path="../../../../../defs/toml/toml.d.ts"/> import toml = require('toml'); toml.parse(...); however, node module export single function, such 'glob' ( https://github.com/isaacs/node-glob ). the node usage of module be: var glob = require("glob") glob("*.js", {}, callback(err, files) { ... }); you'd naively expect this: // glob.d.ts declare function globs(paths:string, options:any, callback:{(err:any, files:string[]):void; ...but because typescripts 'import' semantics bit strange, seems can use 'import .. = require()' statement alias modules . trying call: /// <reference path="../../../../../defs/glob/glob.d.ts"/> import blog = require('glob'); results in: error ts2072: mod...
Read more

openid - Okta: Failed to get authorization code through API call -

i'm integrating okta own idp server using okta's api. i'm implementing authorization code flow following steps below: in own server, use /api/v1/authn endpoint sessiontoken. use sessiontoken obtain authorization calling endpoint: /oauth2/v1/authorize?client_id=" + clientid + "&sessiontoken=" + sessiontoken + "&response_type=code&response_mode=query&scope=openid&redirect_uri=" + redirecturl + "&state=evanyang&nonce=" it's supposed return response status code 302 , location header containing redirect url code value. however, keep getting response status code 200 , without location header, html body saying "you using unsupported browser." , "javascript disabled on browser." according api documentation: http://developer.okta.com/docs/api/resources/oidc.html#authentication-request , sessiontoken parameter sufficient this: an okta one-time sessiontoken. allows api-based ...
Read more

ios - Change Storyboard View using Seague -

i have following code checks connection server, , depending on want change views if no connection found. nsstring *connect = [nsstring stringwithcontentsofurl:[nsurl urlwithstring:@"http://myserver.com"] encoding:nsutf8stringencoding error:nil]; if (connect == null) { [self performseguewithidentifier:@"network_failure" sender:self]; } else { // other code here } my problem not change views. have added storyboard segue between 2 views identifier of network_failure . not have navigation controller or that, problem? thanks help! no not problem. first of all, in objectivec exists nil object oriented null . must use that. so: if(connect == nil) or better: if(!connect) so due fact nil not same of null , probably code does't enter in if scope . you have been able discover breakpoint. anyway: be sure set trigger segue (line) 2 view controller , , name network_failure (that not best name. should instead view1toview2 ) as, m...
Read more