r - grid.layout doesn't like respect and compound units -


using unit.pmax default comparison of widths/heights in gtable proving harder i'd hoped; after several hours of head scratching i've narrowed down situation:

library(grid)  w <- list(unit(1,"null"), unit(1,"null")) class(w) <-  c("unit.list", "unit") h <- unit(1, "in") gl1 <- grid.layout(1, 2, widths = w, heights = h,                    respect = true) grid.newpage() grid.show.layout(gl1) # fine  w2 <- w w2[[1]] <- unit.pmax(unit(1,"null"), unit(1,"null")) gl2 <- grid.layout(1, 2, widths = w2, heights = h,                    respect = false) grid.newpage() grid.show.layout(gl2)# fine  gl3 <- grid.layout(1, 2, widths = w2, heights = h,                    respect = true) grid.newpage() grid.show.layout(gl3)  ## error in grid.call.graphics(l_setviewport, vp, true) :  ##  non-finite location and/or size viewport

so combination of unit.pmax(unit(1,"null"), unit(1,"null")) , respect = true makes grid complain. in case you're wondering, situation come in ggplot2 facet_grid , theme(aspect.ratio = ...).

i can vaguely picture unit.pmax() should simplify null units before attempting use respect parameter, don't know means. in practice though, prevents me improving gtable's cbind/rbind.

any workaround?

edit: i'm not sure how provide minimal example ggplot2, other installing my fork , running 

ggplot(data.frame(x=1:8, y=1:8, f=gl(2,4)), aes(x, y)) +    geom_point() +     facet_grid(f~.) +    theme(aspect.ratio=3) # error in grid.call.graphics(l_setviewport, vp, true) :  #  non-finite location and/or size viewport

so unit.pmax() fails in case, while current comparison method compare.unit(,,pmax) fails in other situations, such as,

p1 = qplot(1, 1); p2 = qplot(1,1) cbind(ggplotgrob(p1), ggplotgrob(p2), size="max") # error in mmm < each : comparison of these types not implemented

it's not optimal, if else fails, rewrite unit.pmax make wish did.

the following function acts unit.pmax() except that, whenever it's asked find maximimum of 2 or more unit objects, in "null" units, returns value of "largest" one, rather expression of form max(x,y,...). (see second code block below example.)

unit.pmax2 <-  function (...)  {     select.i <- function(unit, i) {         unit[i, top = false]     }     x <- list(...)     numargs <- length(x)     if (numargs == 0l)          stop("no arguments @ least 1 expected")     maxlength <- 0l     (i in seq_len(numargs)) if (length(x[[i]]) > maxlength)          maxlength <- length(x[[i]])             ## result <- max(unit.list.from.list(lapply(x, select.i, 1l)))     ul <- grid:::unit.list.from.list(lapply(x, select.i, 1l))                 ##     result <- if(all(sapply(ul, attr, "unit")=="null")) {                     ##                   ul[which.max(ul)]} else {max(ul)}                           ##     if (maxlength > 1l)          (i in 2l:maxlength) {             ## result <- unit.c(result, max(unit.list.from.list(lapply(x,              ##             select.i, i))))             ul <- grid:::unit.list.from.list(lapply(x, select.i, i))          ##             temp <- if(all(sapply(ul, attr, "unit")=="null")) {               ##                         ul[which.max(ul)]} else {max(ul)}                     ##             result <- unit.c(result, temp)                                    ##         }     result }

to see difference between unit.pmax() , unit.pmax2(), compare:

a <- list(unit(1,"null"), unit(1,"null"), unit(1,"null")) b <- list(unit(1,"null"), unit(4,"null"), unit(1,"null")) c <- list(unit(1,"null"), unit(2,"null"), unit(1,"inch"))  class(a) <- class(b) <- class(c) <- c("unit.list", "unit")  unit.pmax(a, b, c) # [1] max(1null, 1null, 1null) max(1null, 4null, 2null) max(1null, 1null, 1inch)     unit.pmax2(a, b, c) # [1] 1null                    4null                    max(1null, 1null, 1inch)

testing out shows works. (note need replace w2[[1]] <- ... w2[1] <- ... avoid complaint when respect = true.)

library(grid)  w2 <- list(unit(1,"null"), unit(1,"null")) class(w2) <-  c("unit.list", "unit") h <- unit(1, "in")  w2[1] <- unit.pmax2(unit(1,"null"), unit(1,"null")) ## w2[[1]] <- unit.pmax(unit(1,"null"), unit(1,"null"))  ## comparison gl3 <- grid.layout(1, 2, widths = w2, heights = h,                    respect = true) grid.newpage() grid.show.layout(gl3)

enter image description here


Comments

Post a Comment

Popular posts from this blog

inversion of control - Autofac named registration constructor injection -

does autofac support specifying registration name in components' constructors? example: ninject's namedattribute . you need use autofac.extras.attributed package on top achieve this so let's have 1 interface , 2 classes: public interface ihello { string sayhello(); } public class englishhello : ihello { public string sayhello() { return "hello"; } } public class frenchhello : ihello { public string sayhello() { return "bonjour"; } } then have consumer class, in want select instance injected: public class helloconsumer { private readonly ihello helloservice; public helloconsumer([withkey("en")] ihello helloservice) { if (helloservice == null) { throw new argumentnullexception("helloservice"); } this.helloservice = helloservice; } public string sayhello() { return this.helloservice.sayhello()...
Read more

ios - Change Storyboard View using Seague -

i have following code checks connection server, , depending on want change views if no connection found. nsstring *connect = [nsstring stringwithcontentsofurl:[nsurl urlwithstring:@"http://myserver.com"] encoding:nsutf8stringencoding error:nil]; if (connect == null) { [self performseguewithidentifier:@"network_failure" sender:self]; } else { // other code here } my problem not change views. have added storyboard segue between 2 views identifier of network_failure . not have navigation controller or that, problem? thanks help! no not problem. first of all, in objectivec exists nil object oriented null . must use that. so: if(connect == nil) or better: if(!connect) so due fact nil not same of null , probably code does't enter in if scope . you have been able discover breakpoint. anyway: be sure set trigger segue (line) 2 view controller , , name network_failure (that not best name. should instead view1toview2 ) as, m...
Read more

verilog - Systemverilog dynamic casting issues -

i've code snippet following in testbench function void write_to_port( my_data_type_base data ); my_data_type_extended data_ext; if(!$cast(data_ext, data)); `uvm_error(get_type_name(), "failed cast"); `uvm_info(get_name(), $psprintf("data_ext :\n%s", data_ext.sprint()), uvm_medium) // write data_ext out port.... endfunction when run it, i'm getting uvm_error "failed cast." i'm not quire sure why $cast not returning 1. can see, i'm printing out extended class data item after casting uvm_info. can see it's being cast properly. if don't use $cast if condition, don't runtime error. isn't coding practice use if dynamic cast check if $cast returning 1 ? what might reason behind cast not returning 1 in above case? i think semicolon on line 'if' not belong? i think consumes if statement, , uvm_error executes regardless of how if evaluates: if(!$cast(data_ext, data)); <- no semico...
Read more